Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Comprehensive remainder round tests #249

Merged
merged 1 commit into from
May 29, 2024
Merged

✅ Comprehensive remainder round tests #249

merged 1 commit into from
May 29, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 18, 2024 •
edited
Loading

What?

  • Add and modify tests to remainder round

Why?

  • We were missing some if we compare it to the community tests. They should be mostly the same

How?

  • Comparing one file to the other and adding the ones that we were missing

Testing?

  • Run the whole remainder round test file

Anything Else?

  • We might be missing some logical paths, please check if you can come up with anything else
  • Also fixed a bug in the async instantiator where creating a finished project was not waiting until the block advanced to the finished transition

@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Apr 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Apr 18, 2024
Merged
@JuaniRios JuaniRios changed the title Improving tests Improving remainder round tests Apr 18, 2024
@JuaniRios JuaniRios changed the title Improving remainder round tests ✅ Comprehensive remainder round tests Apr 18, 2024
@JuaniRios JuaniRios force-pushed the 04-18-restructure_remainder_tests branch 2 times, most recently from 59a5c4c to 62a2f9e Compare April 23, 2024 09:46
@JuaniRios JuaniRios force-pushed the 04-18-_improve_remainder_tests branch from 390df0d to 0cde8d4 Compare April 23, 2024 09:46
Base automatically changed from 04-18-restructure_remainder_tests to main April 23, 2024 11:37
@JuaniRios JuaniRios force-pushed the 04-18-_improve_remainder_tests branch 4 times, most recently from be8b5f1 to c03c0ef Compare April 25, 2024 15:38
@JuaniRios JuaniRios force-pushed the 04-18-_improve_remainder_tests branch from c03c0ef to 41c4be5 Compare May 6, 2024 13:37
@JuaniRios JuaniRios force-pushed the 04-18-_improve_remainder_tests branch 2 times, most recently from 142c479 to 73ef4ec Compare May 14, 2024 11:39
@JuaniRios JuaniRios self-assigned this May 14, 2024
@JuaniRios JuaniRios force-pushed the 04-18-_improve_remainder_tests branch 2 times, most recently from 7c239eb to 11b1bd3 Compare May 14, 2024 12:21
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 14, 2024 12:23
@JuaniRios JuaniRios marked this pull request as ready for review May 14, 2024 12:23
@JuaniRios JuaniRios force-pushed the 04-18-_improve_remainder_tests branch from 11b1bd3 to 591f970 Compare May 16, 2024 09:25
@JuaniRios JuaniRios force-pushed the 04-18-_improve_remainder_tests branch from 591f970 to a7af0fb Compare May 16, 2024 14:40
@JuaniRios JuaniRios merged commit 720e9c6 into main May 29, 2024
@JuaniRios JuaniRios deleted the 04-18-_improve_remainder_tests branch May 29, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic Awaiting requested review from lrazovic

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @vstam1